Skip to content

[Cisco ASA] Fix the processing of the protocol field for 313005 - #8089

Merged
chemamartinez merged 2 commits into
elastic:mainfrom
chemamartinez:sdh-3666-cisco_asa-fix-313005
Oct 4, 2023
Merged

[Cisco ASA] Fix the processing of the protocol field for 313005#8089
chemamartinez merged 2 commits into
elastic:mainfrom
chemamartinez:sdh-3666-cisco_asa-fix-313005

Conversation

@chemamartinez

@chemamartinez chemamartinez commented Oct 4, 2023

Copy link
Copy Markdown
Contributor

Proposed commit message

It fixes the processing of events 313005 with the following format:

<188>May 5 17:51:17 dev01: %ASA-4-313005: No matching connection for ICMP error message: icmp src srcif:192.168.2.2 dst dstif:192.168.2.3 (type 3, code 2) on srcif interface. Original IP payload: protocol 51 src 192.168.2.2 dst 192.168.2.3.

which contains a protocol IANA number inside the original IP payload that was not being parsed.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@chemamartinez chemamartinez self-assigned this Oct 4, 2023
@chemamartinez
chemamartinez marked this pull request as ready for review October 4, 2023 11:32
@chemamartinez
chemamartinez requested a review from a team as a code owner October 4, 2023 11:32
@elasticmachine

elasticmachine commented Oct 4, 2023

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine

elasticmachine commented Oct 4, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-04T11:32:40.640+0000

  • Duration: 17 min 33 sec

Test stats 🧪

Test Results
Failed 0
Passed 23
Skipped 0
Total 23

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Oct 4, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 94.444% (17/18) 👍 69.444
Lines 69.906% (1554/2223) 👎 -30.094
Conditionals 100.0% (0/0) 💚

bhapas
bhapas approved these changes Oct 4, 2023
View reviewed changes

@bhapas bhapas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chemamartinez
chemamartinez merged commit e9ce6ee into elastic:main Oct 4, 2023
@elasticmachine

elasticmachine commented Oct 4, 2023

Copy link
Copy Markdown

Package cisco_asa - 2.25.2 containing this change is available at https://epr.elastic.co/search?package=cisco_asa

@chemamartinez
chemamartinez deleted the sdh-3666-cisco_asa-fix-313005 branch February 6, 2025 10:29
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@chemamartinez
[Cisco ASA] Fix the processing of the protocol field for 313005 (elas…
b92cf93 
…tic#8089)

It fixes the processing of event 313005 which contains a protocol IANA number inside the original IP payload that was not being parsed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bhapas bhapas bhapas approved these changes

Assignees

@chemamartinez chemamartinez

Labels

bugfix Pull request that fixes a bug issue Integration:cisco_asa Cisco ASA

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chemamartinez @elasticmachine @bhapas